Skip to content

⚠️ Default selectors to Nothing if it is nil for MatchingLabelsSelector and MatchingFieldsSelector #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

⚠️ Default selectors to Nothing if it is nil for MatchingLabelsSelector and MatchingFieldsSelector #3279

merged 2 commits into from
Aug 19, 2025
+32 −0

Conversation

acumino
Copy link
Contributor

@acumino acumino commented Aug 13, 2025 •
edited
Loading

If the selector is not set for MatchingLabelsSelector and MatchingFieldsSelector, then the list call panics.
This PR updates MatchingLabelsSelector and MatchingFieldsSelector to default their Selector fields to labels.Nothing() and fields.Nothing() respectively if unset in ApplyToList.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 13, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @acumino. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 13, 2025
@acumino
Copy link
Contributor Author

acumino commented Aug 13, 2025

/cc @sbueringer

@acumino acumino mentioned this pull request Aug 13, 2025
Merged
@troy0820
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 13, 2025
alvaroaleman
alvaroaleman reviewed Aug 13, 2025
View reviewed changes
@acumino acumino requested a review from alvaroaleman August 14, 2025 05:58
@alvaroaleman alvaroaleman changed the title 🐛 Default selectors to Everything if it is nil for MatchingLabelsSelector and MatchingFieldsSelector 🐛 Default selectors to Nothing if it is nil for MatchingLabelsSelector and MatchingFieldsSelector Aug 18, 2025
@alvaroaleman alvaroaleman changed the title 🐛 Default selectors to Nothing if it is nil for MatchingLabelsSelector and MatchingFieldsSelector ⚠️ Default selectors to Nothing if it is nil for MatchingLabelsSelector and MatchingFieldsSelector Aug 18, 2025
@alvaroaleman alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 16a47334870891aed9482e6966ba44660880fdb8

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@alvaroaleman
Copy link
Member

/hold

in case @sbueringer wants to check

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2025
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acumino, alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e4f9a24 into kubernetes-sigs:main Aug 19, 2025
23 of 24 checks passed
@acumino acumino deleted the selec-ehc branch August 19, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@troy0820 troy0820 Awaiting requested review from troy0820

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acumino @k8s-ci-robot @troy0820 @alvaroaleman @sbueringer